Add new device models for Seeed Wio Tracker L1 and Seeed Tracker T1000#176
Add new device models for Seeed Wio Tracker L1 and Seeed Tracker T1000#176MrAlders0n merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for two new Seeed device models to the MeshCore WarDriver's auto-power configuration database. These additions enable automatic power level selection when users connect with Seeed Wio Tracker L1 or Seeed Tracker T1000 devices.
Changes:
- Added two new device model entries (Seeed Wio Tracker L1 and Seeed Tracker T1000) to the device database
- Added a VS Code workspace configuration file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| content/device-models.json | Adds two new nrf52-based Seeed tracker devices with standard 0.3w power configuration and 22 dBm transmit power |
| MeshMapper_WebClient.code-workspace | Adds a VS Code workspace configuration file (should be excluded via .gitignore instead) |
| "power": 0.3, | ||
| "platform": "nrf52", | ||
| "txPower": 22, | ||
| "notes": "Seeed Wio Tracker L1" |
There was a problem hiding this comment.
The notes field simply repeats the device name without providing additional technical information. Looking at other entries in the database, notes fields typically contain useful details about hardware specifications (e.g., "STM32WLE5 integrated LoRa" for Seeed Wio E5 Dev Board, "RAKwireless WisBlock Core" for RAK 4631, "GPS tracker variant" for LilyGo T-Beam). Consider adding more descriptive information about the Seeed Wio Tracker L1 hardware, such as the chipset, LoRa module type, or key features that distinguish it.
| "notes": "Seeed Wio Tracker L1" | |
| "notes": "nRF52-based GPS tracker with onboard LoRa" |
| "power": 0.3, | ||
| "platform": "nrf52", | ||
| "txPower": 22, | ||
| "notes": "Seeed Tracker T1000" |
There was a problem hiding this comment.
The notes field simply repeats the device name without providing additional technical information. Looking at other entries in the database, notes fields typically contain useful details about hardware specifications (e.g., "STM32WLE5 integrated LoRa" for Seeed Wio E5 Dev Board, "RAKwireless WisBlock Core" for RAK 4631, "GPS tracker variant" for LilyGo T-Beam). Consider adding more descriptive information about the Seeed Tracker T1000 hardware, such as the chipset, LoRa module type, or key features that distinguish it.
| "notes": "Seeed Tracker T1000" | |
| "notes": "nRF52 GNSS LoRa-E5 tracker (STM32WLE5 sub-GHz module)" |
| { | ||
| "folders": [ | ||
| { | ||
| "path": "." | ||
| } | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
VS Code workspace files are typically IDE-specific configuration files that should not be committed to version control. The .gitignore file already excludes .vscode/ directory for editor files. Consider adding *.code-workspace to .gitignore and removing this file from the repository. Individual developers can create their own workspace configurations locally if needed.
| { | |
| "folders": [ | |
| { | |
| "path": "." | |
| } | |
| ] | |
| } |
Add new device models for Seeed Wio Tracker L1 and Seeed Tracker T1000